search

dagger / dagger

An engine to run your pipelines in containers
https://dagger.io
Apache License 2.0
10.87k stars 581 forks source link

🐞 Failed `dagger call` check fails due to missing span & does not get fixed when re-running the job #7423

Closed gerhard closed 1 month ago

gerhard commented 3 months ago

What is the issue?

This dagger call check failed:

image

If you look carefully at all the workflows, you will notice that they all succeeded. The last time that this happened, re-triggering the workflow fixed it: https://github.com/dagger/dagger/pull/7407#issuecomment-2119253346

In this case - https://github.com/dagger/dagger/pull/7416 - that didn't work.

https://dagger.cloud/dagger/traces/d2a10b407f509e3a0cb119c9f7d97a7b

image

Is there a different workaround that we could use for this @vito @aluzzardi ?

Dagger version

dagger v0.11.4 (registry.dagger.io/engine) linux/amd64

Steps to reproduce

No response

Log output

No response

gerhard commented 3 months ago

FWIW, there are loads of those failed checks in, even though only one workflow failed:

image
jedevc commented 3 months ago

I suspect this might be the same underlying issue as https://github.com/dagger/dagger/issues/7192, which https://github.com/dagger/dagger/pull/7227 was a hotfix for - the result is still invalid, but at least now the dagger cli no longer crashes.

gerhard commented 3 months ago

Having spoken with @aluzzardi earlier today, some of these checks may have failed due to a ClickHouse migration which killed some in-flight traces.

https://dagger.cloud/dagger/traces/d2a10b407f509e3a0cb119c9f7d97a7b was apparently part of https://github.com/dagger/dagger/pull/7416, but I couldn't find the corresponding failing workflow - all of them passed. I just retriggered the workflow that passed to force this failing dagger call check to pass: https://github.com/dagger/dagger/actions/runs/9160077077/job/25242742782?pr=7416

gerhard commented 1 month ago

OK to close. Reopen if we hit this again. cc @vito