search

dagit / zenc

GHC's Core name mangling (Z-Encoding)
BSD 3-Clause "New" or "Revised" License
5 stars 1 forks source link

Maybe loosen hspec bound. #5

Open maralorn opened 3 years ago

maralorn commented 3 years ago

Currently there is hspec 2.7.10 in Stackage LTS and tests pass fine with that. Maybe you can loosen the bound downward a bit?

maralorn commented 3 years ago

(Builderror on nixos builders for context: https://hydra.nixos.org/build/146096657/nixlog/1/tail)

dagit commented 3 years ago

I'm a little confused here. I didn't expect anyone to run cabal test so I just made those dependencies very strict.

I can't tell what cabal command you used from the log, but on a clean environment I can clone the repo, change the bound to something bogus (eg., hspec == 3.8.*), and cabal build has no issues. It's not until I run something like cabal configure --enable-tests that I run into an issue.

Are you running the test suite and do you need to run the test suite?

maralorn commented 3 years ago

Hey, sorry for not explaining.

I am a packager for the nixos distribution. We generally try to test all packages because under nixos some assumptions from typical systems are not fulfilled and we wanna make sure we don‘t distribute disfunctional packages. We don‘t have to run the tests. But sometimes we actually find issues that didn‘t happen in upstream tests, so we can even give something back to the ecosystem.

The dependency resolution is also a bit weird on nixos. We don‘t build every package with it’s on cabal generated buildplan but try to create on blessed package set which is based on a stackage snapshot and the latest packages from Hackage. That is the explanation why our build infrastructure tried to test your package with hspec 2.7.10.

If you don‘t want to loosen the bounds we can maintain an override downstream. But we general prefer upstream to loosen bounds to make build plans more flexible for everyone.