inferring the OS name from the plugin name is not always valid

dagolden / Dist-Zilla-Plugin-OSPrereqs

List prereqs conditional on operating system

1 stars 5 forks source link

inferring the OS name from the plugin name is not always valid #13

Closed karenetheridge closed 6 years ago

karenetheridge commented 6 years ago

But in these cases the author may not realize they failed to set the OS properly. for example, see:

https://metacpan.org/source/DROLSKY/DateTime-TimeZone-2.18/inc/DTTZBundle.pm#L35 https://metacpan.org/source/DROLSKY/DateTime-TimeZone-2.18/Makefile.PL#L104

karenetheridge commented 6 years ago

yup, I see the travis failures... something interesting is going on. I know how to fix it but it will take a bit of digging to diagnose; this may not happen until the airport tomorrow. I shall not forget!

karenetheridge commented 6 years ago

fixed now! 🤓💃🏼👯‍♂️👯🐣🐢🐡🐾🥝🥑🥐🍡🥂

xdg commented 6 years ago

Rebased and merged in e0977529fe770b57bec6283b6d1dacb15c49036c