search

dagraham / etm-tk

event and task manager
https://pypi.org/project/etmtk/
67 stars 13 forks source link

csv export of custom report does not work and crashes etm #32

Closed aeromorrison closed 9 years ago

aeromorrison commented 9 years ago

The screenshot below shows what I get when I try to export a csv file. The dialog basically does nothing. I'm actually not sure if this is supposed to be a file dialog or what? Anything I click on does nothing. If I cancel the dialog, then etm crashes instantly. I tried turning on the debug dialogs, but there wasn't anything useful written to the output (although etm did not crash).

csv_export_dialog

aeromorrison commented 9 years ago

I've looked at some of the code. The issue is that that FileChoice class expects to already see a file that can be selected from. It seems to default to the load path for etm as the directory. When there isn't an existing csv file, it returns the directory which the subsequent CSV.writer command crashes on because it isn't a file.

If I put an empty csv file in the directory, then I am able to get an export without an error.

I guess I was expecting to see a file dialog where I could select where I want to put the file and the file name. Or, if it could default to an export directory or something, that would work as well.

dagraham commented 9 years ago

Would you try an experiment for me? In view.py line 3982 would you change new=False to new=True and see if it addresses this issue?

Thanks, Dan

aeromorrison commented 9 years ago

Sorry for the delay in testing this. It definitely improves the behavior. I get an extra dialog box where I can enter a file name. I am still limited to putting the file within a sub-directory of my startup user profile directory tree (which is not where I store my data files). It's definitely less confusing behavior.

dagraham commented 9 years ago

I'll add "exportdir" to the options for the config file so you can specify the location you like.

-Dan

aeromorrison mailto:notifications@github.com April 1, 2015 at 4:52 PM

Sorry for the delay in testing this. It definitely improves the behavior. I get an extra dialog box where I can enter a file name. I am still limited to putting the file within a sub-directory of my startup user profile directory tree (which is not where I store my data files). It's definitely less confusing behavior.

— Reply to this email directly or view it on GitHub https://github.com/dagraham/etm-tk/issues/32#issuecomment-88628007.

aeromorrison mailto:notifications@github.com January 28, 2015 at 4:37 PM

The screenshot below shows what I get when I try to export a csv file. The dialog basically does nothing. I'm actually not sure if this is supposed to be a file dialog or what? Anything I click on does nothing. If I cancel the dialog, then etm crashes instantly. I tried turning on the debug dialogs, but there wasn't anything useful written to the output (although etm did not crash).

csv_export_dialog https://cloud.githubusercontent.com/assets/7440842/5947388/a2c170b6-a70a-11e4-8dd8-11c03e297364.png

— Reply to this email directly or view it on GitHub https://github.com/dagraham/etm-tk/issues/32.

dagraham commented 9 years ago

I've added exportdir and changed the documentation. This will be available in the next release.