webpack compatible - Githubissues

dagrejs / dagre-d3

A D3-based renderer for Dagre

MIT License

2.84k stars 587 forks source link

webpack compatible #315

Closed DVLP closed 6 years ago

DVLP commented 6 years ago

suggested PR of some important improvement. Makes webpack and other bundlers work possible. ES6 approach for tree shaking would be a good next step

lutzroeder commented 6 years ago

Can you provide some context on pros and cons of this change? Why is current code not working for Webpack? Would this change break existing browser or Bower scenarios? This PR fails tests when running make for starters...

bursache commented 6 years ago

Does this PR was approved or should we still use workarounds?

lutzroeder commented 6 years ago

We need to understand the pros and cons of this change better. Is this breaking existing scenarios? Why does current approach not work. Also, it will likely require someone to sign up to deal with the fallout...