search

dagrejs / dagre-d3

A D3-based renderer for Dagre
MIT License
2.83k stars 589 forks source link

Publishing new version to NPM? #417

Open zacharybussey opened 3 years ago

zacharybussey commented 3 years ago

Hello,

We are currently using this library in our application, and have ran into some issues with the reference that this library has on D3 version 4. We've worked around the issue for now by forcing it to use v5, but we are wondering if there are any reasons why the current master has not been published as a release to NPM yet? It seems there were no major changes needed to support D3 version 5, but we would like ensure we don't run into any unforeseen issues.

alfredocovaDS commented 3 years ago

Hi, how did you forced the v5? I'm about to start working with this library and I have the feeling that I'll run into the same issue.

zacharybussey commented 3 years ago

In the webpack configuration, I added an alias to resolve the version that the rest of the app uses.

{
    resolve: {
        alias: { d3: path.resolve('./node_modules/d3/index.js') }
    }
}
tbo47 commented 2 years ago

just FYI I ported the project with ES modules https://github.com/tbo47/dagre-es

zacharybussey commented 2 years ago

Cool.

We ended up making a local fork, for this and other reasons.