search

dagronf / QRCode

A quick and beautiful macOS/iOS/tvOS/watchOS QR Code generator/detector library for SwiftUI, Swift and Objective-C.
MIT License
438 stars 57 forks source link

Added new pupil shape hexagon leaf #37

Closed aghaev closed 8 months ago

dagronf commented 8 months ago

@aghaev Hey mate.

Thank you so much for the addition to the library! So great to be able to add new features and styles.

I've taken your code, fixed a few small missing APIs (adding the new pupil generator to the pupil factory) plus added some tests, updated the inline comments to add you in the licensing here and here, and updated the test mechanism to generate samples for the new pupil. You can see your changes added in this commit.

You can see your new hexagonLeaf pupil type in the pupil examples.

This change was added on top of some pending additions I've made to address some Xcode issues, so your code has been added to the new tag 18.0.0.

As a result, I'll close this pull request (as the code has been integrated directly into 18.0.0).

Once again, thank you so much for making this library better!

aghaev commented 8 months ago

First of all, I would like to be grateful to you because you created such a wonderful tool that will make life easier for us developers, and apologize for the fact that you had to supplement my commit, could not figure out how to make a PNG and add it to the project and tests, I did not notice them at all

dagronf commented 8 months ago

Hey @aghaev, you did all the hard work by getting the drawing to work flawlessly. For the most part, the rest of the work you probably wouldn't have known about, mostly because I haven't documented it! And it's quite quick for me to do because I know how to do it (maybe 20 mins of work or so).

Again, many thanks for your work. Please feel free to add more!