search

dagster-io / dagster-cloud-action

Apache License 2.0
13 stars 20 forks source link

Increase location-load-timeout in cloud action #119

Closed gibsondan closed 1 year ago

gibsondan commented 1 year ago

Summary: This is currently set to 10 minutes, which is typically plenty - but can be exceeded in certain situations (ECS plus a slow code location load). It's also not clear whether this particular timeout is giving us any benefit in practice - the agent will almost always either be a) down, in which case the heartbeat timeout will kick in or b) will have its own timeout on the agent side that will move the location into an error state. So there's not much downside in increasing this.

Test Plan: Rebuild and point an action at the new image, verify that when there's an error the github action still errors without timing out.

github-actions[bot] commented 1 year ago

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
from_gh_action View in Cloud Mar 20, 2023 at 03:02 AM (UTC)
prha commented 1 year ago

Should we also rebuild and retag?

prha commented 1 year ago

Yeah, if you land this, I'll pull the version bump out of https://github.com/dagster-io/dagster-cloud-action/pull/118 and create a new PR that bumps the version including this.