search

dagster-io / dagster-cloud-action

Apache License 2.0
12 stars 18 forks source link

Add prerun step to serverless default workflows #124

Closed shalabhc closed 1 year ago

shalabhc commented 1 year ago

This goes live as soon as merged so I'm going to test thoroughly before committing.

Wanted to get feedback on how the prerun is used. The PR is one option where the prerun step returns 'skip' or something else. Another option is to have the prerun one of docker-deploy, pex-deploy or skip and then and add simpler conditions like the following:

      - name: Parse cloud workspace
        if: steps.prerun.outputs.result == 'docker-deploy'
        ...

      - name: Checkout
        if: steps.prerun.outputs.result == 'fast-deploy'
        ...

      - name: Build and deploy Python executable
        if: steps.prerun.outputs.result == 'fast-deploy'
        ...

Thoughts?

github-actions[bot] commented 1 year ago

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
from_gh_action Deploy failed Apr 07, 2023 at 11:21 PM (UTC)
shalabhc commented 1 year ago

Withdrawn. Will send a different PR.