search

dagster-io / dagster-cloud-action

Apache License 2.0
13 stars 20 forks source link

Change the prerun step so it returns the next action #127

Closed shalabhc closed 1 year ago

shalabhc commented 1 year ago

This PR changes the prerun return value to one of pex-deploy, docker-deploy or skip. This simplifies the conditional in the following steps and introduces a single decision point.

Note the prerun step is not used anywhere yet.

github-actions[bot] commented 1 year ago

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
from_gh_action Deploy failed Apr 07, 2023 at 11:23 PM (UTC)
slopp commented 1 year ago

I like the idea of consolidating the decision points, but I do wonder if some teams will need more flexibility. For instance in Purina we follow the branch deployment best practice of running a job to create a DB shallow clone on PR open, and running another job to delete the DB clone on PR close. In this case I think we'd still want the pre-run step, but I'm not sure we'd want to skip the rest

But I guess it's fine if skip is only being interpreted by the other standard dagster deploy actions? So you could have a pipeline with custom steps that still run after the skip pre-run result?

shalabhc commented 1 year ago

But I guess it's fine if skip is only being interpreted by the other standard dagster deploy actions? So you could have a pipeline with custom steps that still run after the skip pre-run result?

@slopp yes. I initially had the prerun fail but then decided just returning a result is best. Our steps will interpret it but other user steps will still run.