Allow a full deployment not called 'prod' for pex deploys

dagster-io / dagster-cloud-action

Apache License 2.0

12 stars 18 forks source link

Allow a full deployment not called 'prod' for pex deploys #155

Closed shalabhc closed 11 months ago

shalabhc commented 11 months ago

The default deployment name can be overridden using the deployment: input to the action. Eg

Test Plan

Rename a deployment to something other than prod Point the build_deploy_python_executable action in deploy.yml to this branch and add the deployment: input Verify that the workflow deployment works Rename deployment back to prod Verify that workflow deployment fails Remove deployment: input Verify that the workflow deployment works again

Ran all above steps in a test org successfully.

github-actions[bot] commented 11 months ago

Your pull request is automatically being deployed to Dagster Cloud.

Location	Status	Link	Updated
`from_gh_action`		Deploy failed	Oct 13, 2023 at 05:58 PM (UTC)

gibsondan commented 11 months ago

How suspicious is the test failure here?

johannkm commented 11 months ago

This is different from how you set it for hybrid deploys right? Could we make both use this env var?

shalabhc commented 11 months ago

ah good points re consistency. I'll make this self consistent with how we do serverless docker deploys using the input field instead.

eventually i want to replace the serverless workflow entirely with the new workflows we use for hybrid (https://github.com/dagster-io/dagster-cloud-hybrid-quickstart/) but haven't gotten around to testing, releasing and documenting that.

shalabhc commented 11 months ago

@gibsondan - made this consistent with docker deploys using a new deployment: input. Tested manually successfully:

The test failures have been happening for a while and we haven't gotten around to identifying or fixing them yet.