search

dagster-io / dagster-cloud-action

Apache License 2.0
13 stars 20 forks source link

Explicitly spell out that all paths will trigger branch deployment action #168

Closed salazarm closed 6 months ago

salazarm commented 7 months ago
  1. Updating our actions to specify that all paths will trigger the action.
  2. Adding a filter step that helps avoid the issue described in this issue. TLDR: rebase commits end up re-triggering actions even if the PR being rebased didn't change the specified paths.

This should help our users not run into the same issue we ran into.

One thing that is not good about this approach is that the check_paths step runs no matter what. Ideally we could skip it in the default case of "**" (all paths) triggering the action.

github-actions[bot] commented 7 months ago

Your pull request is automatically being deployed to Dagster Cloud.

Location Status Link Updated
from_gh_action View in Cloud May 08, 2024 at 04:10 PM (UTC)