WebUI mishandles commas in partition - Githubissues

dagster-io / dagster

An orchestration platform for the development, production, and observation of data assets.

https://dagster.io

Apache License 2.0

11.12k stars 1.39k forks source link

WebUI mishandles commas in partition #15105

Open samwong1990 opened 1 year ago

samwong1990 commented 1 year ago

Dagster version

dagster, version 1.3.13

What's the issue?

On the asset details page:

I am using a json string as dynamic partition.

Unselecting Select All works as expected

Clicking the {"scenario":1, "version":1} line, we see it gets confused, and thinks there are 2 partitions selected.

If I follow through then the backfill page looks like this

And launches 2 partitioned runs

What did you expect to happen?

Should handle commas correctly, and treat all partition name as a simple string.

How to reproduce?

Use any partition with comma in it

Deployment type

Local

Deployment details

No response

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

lucas-asimov commented 7 months ago

Hi! Just wondering if there's any update here? We're using dynamic partitions + JSON strings - which works well in theory - but this issue is causing us to do some pretty wonky workarounds (replace "," in the JSON string with another character, then replace the replacement to get back to valid JSON).