dagster-io / dagster

An orchestration platform for the development, production, and observation of data assets.
https://dagster.io
Apache License 2.0
11.15k stars 1.4k forks source link

1.8.2 - ImportError: cannot import name 'runtime_version' from 'google.protobuf' #23854

Closed rossserven closed 2 days ago

rossserven commented 3 weeks ago

Dagster version

1.8.2

What's the issue?

The 'Prepare DBT project for deployment' Github Action step is failing with

File "/home/runner/.local/lib/python3.8/site-packages/grpc_health/v1/health_pb2.py", line 9, in <module> from google.protobuf import runtime_version as _runtime_version ImportError: cannot import name 'runtime_version' from 'google.protobuf' (/home/runner/.local/lib/python3.8/site-packages/google/protobuf/__init__.py) Error: Process completed with exit code 1.

I am not seeing the same error under 1.8.1 install_requires=[ "dagster<1.8.2", "dagster-cloud<1.8.2", "dagster-dbt<1.8.2", ... ],

What did you expect to happen?

No response

How to reproduce?

No response

Deployment type

Dagster Cloud

Deployment details

No response

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a πŸ‘! We factor engagement into prioritization.

gibsondan commented 2 weeks ago

Hi @rossserven - thanks for reporting this, we're fixing the action in https://github.com/dagster-io/dagster-cloud-action/pull/195. You can apply that same change to your github repo and it should work (specifically, replacing pip install pip --upgrade with python -m pip install pip --upgrade in the two action YAML files).

gibsondan commented 2 weeks ago

This is now fixed for new users going through the flow. If the github action has already been scaffolded in a github repo, applying the change above will fix it.

gibsondan commented 2 weeks ago

Hold that thought actually - we temporarily rolled back the fix, but it should be live soon. The above workaround should still work in the meantime.

cyclonstep commented 2 days ago

@gibsondan hello, I also found this problem lately and it really locks me for getting the newest version. Is this actually still in the broken state now or can I just re-scaffold it?

gibsondan commented 2 days ago

This is fixed now if you re-scaffold, sorry for not updating this task. Or you can apply that change above to the action yaml if you have already scaffolded.

cyclonstep commented 2 days ago

@gibsondan thank you very much πŸ‘ If I don't want to re-scaffold the project, do I just need to update the action yaml like this? https://github.com/dagster-io/dagster-cloud-action/pull/195/files#diff-050229b268df6169d016a0f0c43b5f7ab7280b21541d86bb3412a08a8c579ae4

gibsondan commented 2 days ago

That’s all you should need to do to make it work, yes