dagster-io / dagster

An orchestration platform for the development, production, and observation of data assets.
https://dagster.io
Apache License 2.0
11.53k stars 1.45k forks source link

`UrlMetadataValue` cannot open local files #24243

Open j-blackwell opened 1 month ago

j-blackwell commented 1 month ago

Dagster version

1.8.0

What's the issue?

Nothing happens when clicking on local links. Forcing open in new tab gives: about:blank#blocked Copying and pasting does work, but is annoying.

What did you expect to happen?

The file is opened in the browser

How to reproduce?

import dagster as dag

@dag.asset(metadata={"test_url": dag.UrlMetadataValue("file:///home/...")})
def my_asset():
  return None

Deployment type

Local

Deployment details

No response

Additional information

https://github.com/dagster-io/dagster/issues/3416#issuecomment-1373725249

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

kristianandre commented 1 month ago

Might not be what you need, but have you tried using MetadataValue.path?

j-blackwell commented 1 month ago

Might not be what you need, but have you tried using MetadataValue.path?

Thanks @kristianandre , I believe this also just copies to the clipboard rather than opening in the browser, sadly.