dagster-io / dagster

An orchestration platform for the development, production, and observation of data assets.
https://dagster.io
Apache License 2.0
11.98k stars 1.5k forks source link

dagster/row_count metadata not visible in asset events view #25566

Open dschafer opened 1 month ago

dschafer commented 1 month ago

What's the issue?

In the /assets/example?view=events view of an asset, dagster/row_count is filtered out of the metadata, but it does not appear in another place in the UI.

What did you expect to happen?

Either the row_count metadata shouldn’t be filtered in this view (easiest), or there should be a dedicated UI treatment for it in this view.

How to reproduce?

With this test file, run with dagster dev -f thisfile.py

from dagster import (
    Output,
    asset,
)

@asset()
def example():
    return Output(0, metadata={"dagster/row_count": 10, "someotherdata": 5})

Materialize the asset twice, then go to http://127.0.0.1:3000/assets/example. You can see the row count right underneath status (it's "promoted" to a dedicated UI treatment), and the someotherdata in the metadata section.

Screenshot 2024-10-26 at 15 49 21

But if you go to http://127.0.0.1:3000/assets/example?view=events , you can still see someotherdata in metadata, but dagster/row_count neither appears in metadata nor in a dedicated treatment.

Screenshot 2024-10-26 at 15 48 58

So if you're using this view to look back in time to see how row count has changed over materializations, there's no way to do so.

Dagster version

dagster, version 1.8.9

Deployment type

Local

Deployment details

No response

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization. By submitting this issue, you agree to follow Dagster's Code of Conduct.

dschafer commented 1 month ago

Given that this is UI, guessing this is CC @hellendag

dschafer commented 1 month ago

Seems to be https://github.com/dagster-io/dagster/blob/dea8214e3787be1f720d00f741eeffdfdff7f181/js_modules/dagster-ui/packages/ui-core/src/assets/AssetEventMetadataEntriesTable.tsx#L337

dschafer commented 1 month ago

Might be related to #22324 – CC @rexledesma

hellendag commented 4 weeks ago

@bengotow is on it!