dagster-io / dagster

An orchestration platform for the development, production, and observation of data assets.
https://dagster.io
Apache License 2.0
11.85k stars 1.49k forks source link

Not possible to use postgres image config in the helm chart #25898

Open psarka opened 1 week ago

psarka commented 1 week ago

What's the issue?

There is section in the dagster helm chart values to configure the postgresql:

postgresql:
  # set postgresql.enabled to be false to disable deploy of a PostgreSQL database and use an
  # existing external PostgreSQL database
  enabled: true

  # Used by init container to check that db is running. (Even if enabled:false)
  image:
    repository: "library/postgres"
    tag: "14.6"
    pullPolicy: IfNotPresent

This image is used both for webserver / daemon init images as well as for the database via bitnami helm. It is not possible to change that value to some other registry.

And this impossibility arises from the fact that in dagster helm repository and tag are composed to url as {repository}:{tag}. While in bitnami they are composed to url as docker.io/{repository}:{tag}.

It should be able to disable that docker.io prefix by setting image.registry to null and global.imageRegistry to null, but it does not seem to work.

What did you expect to happen?

Setting repository + tag should work in postgresql sections like it works in other sections

How to reproduce?

No response

Dagster version

dagster 1.7.2

Deployment type

Dagster Helm chart

Deployment details

No response

Additional information

There is a ticket with the same issue (I think), closed by the reporter without any solution: https://github.com/dagster-io/dagster/issues/12910

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization. By submitting this issue, you agree to follow Dagster's Code of Conduct.

flozgom commented 1 week ago

Hi @psarka, I'm also experimenting with some issues related to this. In my case, I'm using a specific registry that I'm able to overwrite the one in the PostgreSQL section. However, when trying to deploy the daemon or the webserver, it fails because the chart is also in a container called check-db-ready, which does not point to my explicit registry. I've opened a PR here https://github.com/dagster-io/dagster/pull/25946