ANTLR only allow traversal on certain expressions

dagster-io / dagster

An orchestration platform for the development, production, and observation of data assets.

https://dagster.io

Apache License 2.0

11.79k stars 1.48k forks source link

ANTLR only allow traversal on certain expressions #26068

Closed briantu closed 23 hours ago

briantu commented 1 day ago

Summary & Motivation

We discovered some ambiguity caused by traversal expressions that may cause parser to return an unexpected asset selection. For example, currently the parser reads *key:a and key:b* as *(key:a and key:b)*. We believe this is unintuitive, so we've decided to force the traversal tokens to only apply to the expression they are immediately next to.

briantu commented 1 day ago

#26068 👈 (View in Graphite)
#26018
#26014
#25998
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions[bot] commented 1 day ago

Deploy preview for dagit-core-storybook ready!

✅ Preview https://dagit-core-storybook-bs1me6ump-elementl.vercel.app https://briantu-fix-antlr-traversal-precedence.core-storybook.dagster-docs.io

Built with commit af6777c767dedd021a3d3018d92a2f08508adada. This pull request is being automatically deployed with vercel-action

briantu commented 23 hours ago

Merge activity

Nov 21, 3:44 PM EST: A user started a stack merge that includes this pull request via Graphite.
Nov 21, 3:57 PM EST: Graphite rebased this pull request as part of a merge.
Nov 21, 3:58 PM EST: A user merged this pull request with Graphite.