dagster-io / dagster

An orchestration platform for the development, production, and observation of data assets.
https://dagster.io
Apache License 2.0
11.91k stars 1.49k forks source link

add dockerignore #26075

Closed neilfulwiler closed 4 days ago

neilfulwiler commented 4 days ago

Summary & Motivation

This lets us use the dagster repo as a docker context, without having to transfer a lot of cruft through docker that would then get ignored anyway

How I Tested These Changes

Ran a docker build locally with /code/dagster as the context, and verified that before this change the context was unmanegeable (several GB) and after it was basically immediate

neilfulwiler commented 4 days ago

well so the annoying thing is that the format here is not the same as .gitignore format, so its possible that there is stuff on other people's machines that we're .gitignore-ing properly but will still be pulled into the context, so basically YMMV but these are the big ones (extra stuff in the context isn't strictly bad, especially considering the actual docker builds will be run on buildkite machines with fresh checkouts)

neilfulwiler commented 4 days ago

Merge activity