search

dagster-io / dagster

An orchestration platform for the development, production, and observation of data assets.
https://dagster.io
Apache License 2.0
11.91k stars 1.49k forks source link

regenerate helm schema with pydantic 2.10.0 #26076

Closed gibsondan closed 4 days ago

gibsondan commented 4 days ago

Summary: 2.10.0 appears to have introduced a benign schema change when its regenerated - I guess because this field is a Literal[true] instead of a boolean in the schema.

Test Plan: BK

NOCHANGELOG

Insert changelog entry or delete this section.

Summary & Motivation

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

gibsondan commented 4 days ago

unless the field is supposed to be a boolean and not a Literal[True]? Is the idea that it won't work if you set it to False? https://github.com/dagster-io/dagster/blob/master/helm/dagster/schema/schema/charts/dagster/subschema/rabbitmq.py#L18