dagster-io / dagster

An orchestration platform for the development, production, and observation of data assets.
https://dagster.io
Apache License 2.0
11.79k stars 1.48k forks source link

[ui] Open evaluation dialog from sensor page #26079

Closed hellendag closed 22 hours ago

hellendag commented 1 day ago

Summary & Motivation

When viewing automaterialization evaluations from a sensor page, open the evaluation details in a dialog instead of the asset's Automation tab. This means opening a dialog on top of another dialog, instead of navigating away.

This change is in preparation for updating the Automation tab to show the list of evaluations as the main content, which will involve opening evaluation details in a dialog as well.

https://github.com/user-attachments/assets/4adca993-6463-4aec-85d5-b4f0bf37dfef

How I Tested These Changes

View an enabled automation sensor. View materializations in dialog, then view individual evaluations. Verify that the dialog opens and renders properly, and that partitioned assets behave correctly when choosing partitions within the dialog.

View Automation tab on individual assets, verify that these remain unaffected and behave the same as before.

Changelog

[ui] Open automation sensor evaluation details in a dialog instead of navigating away.

hellendag commented 1 day ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions[bot] commented 1 day ago

Deploy preview for dagit-core-storybook ready!

✅ Preview https://dagit-core-storybook-iudj6tw6n-elementl.vercel.app https://dish-open-evaluation-dialog.core-storybook.dagster-docs.io

Built with commit 586d780f90cd20090ab0b4ec9490df0e1591d633. This pull request is being automatically deployed with vercel-action

hellendag commented 22 hours ago

Merge activity