search

dagster-io / dagster

An orchestration platform for the development, production, and observation of data assets.
https://dagster.io
Apache License 2.0
11.61k stars 1.46k forks source link

Hanging resource init user code can't be terminated/interrupted #3418

Open gibsondan opened 3 years ago

gibsondan commented 3 years ago

Summary

Since we swallow KeyboardInterrupts during execution, hanging user code that happens during resource init is likely not able to be terminated.

We should re-enable KeyboardInterrupts during that user code execution (and audit other user_code_error_boundary callsites during execution to make sure there aren't similar issues elsewhere).

Reproduction

Dagit UI/UX Issue Screenshots

Additional Info about Your Environment

Message from the maintainers:

Impacted by this bug? Give it a 👍. We factor engagement into prioritization.

alangenfeld commented 3 years ago

did this get fixed @gibsondan ?