dagster-io / fake-star-detector

https://github.com/dagster-io/dagster
234 stars 19 forks source link

print -> context.log.debug to surface relevant logs #9

Open redeux opened 1 year ago

redeux commented 1 year ago

Resolves #8

While making this I noticed that the print messages were originally context.log.info messages. I can see why info was not ideal. However, I still think it's important to have the option to surface these messages while running the project against a repository with more stargazers than can be captured in a single run. Otherwise, it's not entirely clear what's happening when execution is paused due to token depletion.

I think setting these logs to debug provides a good compromise. The logs don't clutter the UI by default, but the user still has the option to see them if desired.

I left print(f"User {user} not found.") in place because I couldn't think of a use case where that was an important log to surface during execution time.

I also corrected a minor typo that I found while reading the comments.