search

dagurval / doublespend.cash

Website for tracking double spends on the Bitcoin Cash network
18 stars 14 forks source link

Visualization of txids missing a character #1

Closed dagurval closed 6 years ago

dagurval commented 6 years ago

In Flowee I have double-spend detection as well, which is needed for some other components like a point-of-sale solution build on Flowees APIs. So when I noticed this in my logs today I thought I'd check if we got the same data; 16:17:54 [2501] Double spend found b86a8a170b55ebb516dd5dde036b85b4acea25a26de8e83ee0764757ec94c851 acb4eb8a07b6124fe14903bed92ce653081f0e0ca439a2d983154609e3fb3ceb·

I noticed that the '1' and the 'b' were missing at the end of your version of events. But the clickable link has it, so its purely a minor rendering issue.

(Thanks for the report @zander)

This is possibly off-by-one error in https://github.com/dagurval/doublespend.cash/blob/master/respend/websitebuilder.py#L128

@chaintip 120 days

DJMcNab commented 6 years ago

Is it possibly just the :-1 on: https://github.com/dagurval/doublespend.cash/blob/f7ede42db72c650d35f9faaa7db681a65a9c50f0/respend/websitebuilder.py#L130 It should be txid[-3:]

See:

"test"[:-1] == "tes"

Unless I'm mistaken, I'd say it hardly seems worth the bounty for you, to me. I'll give you this for free.

dagurval commented 6 years ago

Thanks @DJMcNab. I'll save it for the bounty for a new issue :-)

chaintip commented 6 years ago

0 BCH| ~ 0.00 USD has now been tipped to this issue. To claim this bounty, get a pull request merged with @chaintip fixes #1 in the creation comment.