search

dagwieers / asciidoc-odf

ODF backend for AsciiDoc
98 stars 26 forks source link

Page breaks (soft-page-break element) fails to work #10

Closed dagwieers closed 13 years ago

dagwieers commented 13 years ago

Apparently the soft-page-break element does not seem to have any effect. If you add page breaks from within LibreOffice, it seems to fall back to use page-breaks-after attributes as part of the paragraph style. Which is something very hard to do by the way asciidoc does substitutions.

One option to implement is to make it a paragraph option, although we should be very careful with adding ODF specific syntax to asciidoc.

elextr commented 13 years ago

On 5 October 2011 04:23, Dag Wieërs reply@reply.github.com wrote:

Apparently the soft-page-break element does not seem to have any effect. If you add page breaks from within LibreOffice, it seems to fall back to use page-breaks-after attributes as part of the paragraph style. Which is something very hard to do by the way asciidoc does substitutions.

Why is it hard, can't we just have a pagebreakparagraph style defined and have [pagebreak-blockmacro] generate an empty paragraph with the relevant style instead of just a soft break. Thats what lo does.

One option to implement is to make it a paragraph option, although we should be very careful with adding ODF specific syntax to asciidoc.

Lets not do that.

Cheers Lex

Reply to this email directly or view it on GitHub: https://github.com/dagwieers/asciidoc-odf/issues/10

dagwieers commented 13 years ago

The problem with empty paragraphs (afaict) is that they implicitly add a line-break. I have this problem with the preamble section in case it is empty :-/ But it definitely is an option.

elextr commented 13 years ago

On 5 October 2011 19:27, Dag Wieërs reply@reply.github.com wrote:

The problem with empty paragraphs (afaict) is that they implicitly add a line-break. I have this problem with the preamble section in case it is empty :-/ But it definitely is an option.

Well, it adds a line if you insert the page break interactively too.

blah blah

becomes

blah

blah so I'm not sure we can fix it. Cheers Lex > ## > > Reply to this email directly or view it on GitHub: > https://github.com/dagwieers/asciidoc-odf/issues/10#issuecomment-2295746
dagwieers commented 13 years ago

If you add the page-break in LibreOffice from an existing paragraph or other element (eg. a list-item), it does not introduce a new empty paragraph. However, I have implemented it like this now. It's better to have this for now, than not having it. And if anyone is bothered by the behaviour, he is welcome to improve the implementation :-D

elextr commented 13 years ago

On 9 October 2011 10:56, Dag Wieërs reply@reply.github.com wrote:

If you add the page-break in LibreOffice from an existing paragraph or other element (eg. a list-item), it does not introduce a new empty paragraph.

hmmm, it did for me, maybe it depends on where you add it.

However, I have implemented it like this now. It's better to have this for now, than not having it. And if anyone is bothered by the behaviour, he is welcome to improve the implementation :-D

agreed

Cheers Lex

Reply to this email directly or view it on GitHub: https://github.com/dagwieers/asciidoc-odf/issues/10#issuecomment-2334456