dagwieers / asciidoc-odf

ODF backend for AsciiDoc
98 stars 26 forks source link

"make link" complains about [[ #40

Closed fidergo-stephane-gourichon closed 10 years ago

fidergo-stephane-gourichon commented 10 years ago

Version used:

commit ccbc9d31f902b01f5e82187c2af6f79400fb6209
Date:   Sun Jul 7 22:42:08 2013 +0200

    The usual updates to the examples

Command run:

LC_ALL=C make link

= Linking odp backend
[[ -e /etc/asciidoc/backends/odp ]] && rm -ir /etc/asciidoc/backends/odp
/bin/sh: 1: [[: not found
make: [link] Error 127 (ignored)

Cause: [[ is a bashism, not portable sh. Recent bash, when run with /bin/sh do not know [[ for the sake of compliance.

Solution: either live with bash and say it:

git diff HEAD^..HEAD

diff --git a/Makefile b/Makefile
index a8f2ec2..d1252ba 100644
--- a/Makefile
+++ b/Makefile
@@ -1,3 +1,5 @@
+SHELL=/bin/bash
+
 version = 0.1

 bindir = /usr/bin

Or review the Makefile, remove all bashism, test with strict conditions, etc. There are more errors, fixing this one makes just one less to be fixed.

dagwieers commented 10 years ago

Pull-request please ! ;-)