search

dagwieers / vmguestlib

Python API for interacting with VMware's VMGuestLib SDK
GNU General Public License v2.0
28 stars 12 forks source link

Allow guestlib to find open-vm-tools version #2

Closed stevenschlansker closed 8 years ago

dagwieers commented 8 years ago

Looks good, but why print the date/time each cycle ?

stevenschlansker commented 8 years ago

It's useful to correlate with other sources of data -- I was trying to e.g. correlate it with JVM pauses or spikes on our Kibana dashboard. It makes the log much more useful for postmortem.

If you don't like it I can take it out, it just seems like it might help someone else out some day.

makefu commented 8 years ago

@stevenschlansker i suggest you remove the timestamp addition from this PR and create a new one. It is always better to have separate PRs for different features added to the project.

stevenschlansker commented 8 years ago

done as #3