dahlb / ha_carrier

Carrier Infinity Integration for Home Assistant
MIT License
42 stars 3 forks source link

Change filter icon to mdi:air-filter #25

Closed deviantintegral closed 1 year ago

deviantintegral commented 1 year ago

Checklist

Is your feature request related to a problem? Please describe.

I was surprised to see the air filter life remaining exposed as a "battery". However, it's clear from https://github.com/dahlb/ha_carrier/blob/cd4925a8b0745063f175c23363e2d40800aa24c3/custom_components/ha_carrier/sensor.py#L156-L160 this is intentional. Looking at https://developers.home-assistant.io/docs/core/entity/sensor/#available-device-classes, I suppose it really is the best class to use.

Describe the solution you'd like

Can we set the default icon to mdi:air-filter instead of the battery? that will make it so a default view in a dashboard of the filter entity at least matches what it is.

Describe alternatives you've considered

I double checked to see if there other sensor classes to use instead.

Additional context

What this looks like when you change the icon:

image
dahlb commented 1 year ago

fixed in 1.20.3, thanks