search

dahlb / ha_hatch

Home Assistant Integration for Hatch Rest Mini
MIT License
77 stars 16 forks source link

feat:Add Clock, Toddler Lock, and Charge Status to Hatch 2nd Gen #30

Closed trevorglaser closed 1 year ago

trevorglaser commented 1 year ago

I don't believe that the Toddler Lock is completely working. Looking for some help on that one as my Hatch is not currently connecting so I am not able to test.

trevorglaser commented 1 year ago

@w1ll1am23 would you be able to test this and help figure out the Toddler Lock? I believe it is close but I don't think it is 100% working.

dahlb commented 1 year ago

@trevorglaser please recommit these with commit messages that conform to Semantic Commit Messages

w1ll1am23 commented 1 year ago

Tested the toddler lock and added a fix over here https://github.com/dahlb/hatch_rest_api/pull/11

w1ll1am23 commented 1 year ago

@trevorglaser tested from the API perspective going to try to test this out now.

I noticed that my clock at the moment is off and as the flags set to 8 not 0. That flags must be some sort of bitmap that controls the on/off as well as the 24 hour and maybe timezone or something?

Using the 0 and 32768 does seem to turn on/off though.

I think setting the brightness and turning the clock on/off should be split out in the library though, I shouldn't have to change the brightness value to turn off the clock right?

w1ll1am23 commented 1 year ago

With the updated library change this all seems to be working as expected. I think we should move the flags out of this and up to the library as I mentioned above but other than that this seems to be good to go.

Need to figure out a way to not create battery and charging sensors for the non-battery gen 2...

trevorglaser commented 1 year ago

@trevorglaser please recommit these with commit messages that conform to Semantic Commit Messages

Sorry I am obviously new to all of this. I will figure out how to fix it.

trevorglaser commented 1 year ago

With the updated library change this all seems to be working as expected. I think we should move the flags out of this and up to the library as I mentioned above but other than that this seems to be good to go.

Give me some time and I can work on moving the flags to the library level. I am still learning so it takes me much longer to figure it all out than I'm sure it does for you guys. I just got my hatch working again and everything with this PR is working for me. However, my light.turn_off for the light is not doing anything. When I turn on the light and then turn it back off it does not respond to the turn off command. I am going to look into it.

trevorglaser commented 1 year ago

With the updated library change this all seems to be working as expected. I think we should move the flags out of this and up to the library as I mentioned above but other than that this seems to be good to go.

This has been completed. A new library PR is needed.

dahlb commented 1 year ago

picky release scripts skipped your commit because this pr was missing a space after the : , i added a commit with a new line in the readme to force a release to include this feature.