search

dahlb / ha_kia_hyundai

A Home Assistant HACS integration that supports Kia Connect(Uvo). The integration supports the USA.
MIT License
17 stars 6 forks source link

Integration is using deprecated `DEVICE_CLASS_*` constants #65

Closed frenck closed 1 year ago

frenck commented 1 year ago

Please check Services, Known Bug / Issues and Troubleshooting over here first: https://github.com/dahlb/ha_kia_hyundai/blob/master/README.md Region and Brand of car

n/a

Describe the bug

This custom integration uses deprecated DEVICE_CLASS_* constants in its codebase.

The DEVICE_CLASS_* constants have been deprecated and replaced in Home Assistant Core 2021.12 (over a year ago). I would highly suggest updating/migrating this integration to the new enums.

For example, for the device classes supported by the sensor platform, there is now a SensorDeviceClass enum. So if a sensor previously used the DEVICE_CLASS_ENERGY constant, it should now use SensorDeviceClass.ENERGY. Other platforms (like binary_sensor, and number) provide similar enumerations for their supported device classes.

The migration thus only consists of replacing constants with an enumeration member and is, therefore, very low impact and should be fairly straightforward.

If I can help resolve any questions regarding this change or migration, feel free to ask or respond to this issue. I'm happy to help!

Kindest regards,

../Frenck

Debug logs if an error occurred

n/a

To Reproduce

n/a

Expected behavior

n/a

Screenshots

n/a

Additional context

n/a

frenck commented 1 year ago

You are unstoppable! 💪

Thank you for the quick responses and effort, appreciated 👍

../Frenck