search

dahlia / iterfzf

Pythonic interface to fzf, a CLI fuzzy finder
https://pypi.python.org/pypi/iterfzf
GNU General Public License v3.0
164 stars 19 forks source link

add header and color options #12

Open mvrozanti opened 4 years ago

daturkel commented 4 years ago

This would be a great feature. I'd love to help get it merged but I can't tell what is failing in the CI. Any help @dahlia ?

mvrozanti commented 4 years ago

I see a message about python 2 usage on the beggining of the console output. Maybe this has something to do with it?

daturkel commented 4 years ago

I'm guessing the python2 tests are failing with the f-string syntax. Try replacing: f'{k}:{v}' with str(k) + ":" + str(v)

mvrozanti commented 4 years ago

I just replaced this part but the build still fails. That's weird

daturkel commented 4 years ago

this one looks like a different error. i defer to @dahlia who probably has a better understanding of the CI setup. but the syntax error from before is gone and now we just have:

lint run-test: commands[0] | flake8 iterfzf.py setup.py
iterfzf.py:0:1: E902 FileNotFoundError: [Errno 2] No such file or directory: 'iterfzf.py'
ERROR: InvocationError for command 'C:\projects\iterfzf\.tox\lint\Scripts\flake8.EXE' iterfzf.py setup.py (exited with code 1)
dahlia commented 4 years ago

@mvrozanti Sorry for my late response. As @daturkel explained, it was an error that has existed before changes you made, and I finally fixed the error in the master. The error would be gone if you rebase your commits on the current master.

mvrozanti commented 4 years ago

Still failing :confused: .

I actually just tried pulling from upstream. Do I really need to rebase?