search

dahlia / iterfzf

Pythonic interface to fzf, a CLI fuzzy finder
https://pypi.python.org/pypi/iterfzf
GNU General Public License v3.0
164 stars 19 forks source link

Support for --ansi flag #13

Closed giftig closed 4 years ago

giftig commented 4 years ago

I'd like to use ansi colour in my options but currently iterfzf won't pass the flag through. This will pass it through.

giftig commented 4 years ago

While I'm here, can I suggest exposing the ability to add extra arguments to the underlying command? You're not supporting every argument, but it'd be nice if I could unblock myself by providing extra_args=['--ansi', '--color=light'] as raw input to work around it in the event that the feature isn't in yet or fzf releases a new feature. I'm likely to have to pip install my own fork of your project or monkeypatch in my own iterfzf() function in the meantime since I can't access the cmd there. I'm happy to raise a PR for that if you agree with the principle.

It's very useful to see an fzf wrapper working so readily out of the box and handling installation of fzf itself though, so thanks for the project.

dahlia commented 4 years ago

Ah, could you update iterfzf/__init__.pyi file as well? It's for typing support.