In some contexts, fzf will immediately fail with 'inappropriate ioctl for device' (e.g., if you are on a non-interactive shell). From the code's perspective, this failure is silent and can only be inferred through the absence of a return value. I think it would be better to raise an exception so that it can be handled more gracefully, and to furthermore catch the error message so as to avoid side effects.
In some contexts,
fzf
will immediately fail with 'inappropriate ioctl for device' (e.g., if you are on a non-interactive shell). From the code's perspective, this failure is silent and can only be inferred through the absence of a return value. I think it would be better to raise an exception so that it can be handled more gracefully, and to furthermore catch the error message so as to avoid side effects.