dahlia / wikidata

Wikidata client library for Python
https://pypi.org/project/Wikidata/
GNU General Public License v3.0
337 stars 31 forks source link

Manage url and http exceptions for non-existent entities #11

Closed k----n closed 4 years ago

k----n commented 6 years ago

Entity does not exist so the JSON is not returned by wikidata.

When an http or url exception is raised by a bad request, the entity data is set to none.

An empty entity is returned with an id that does not exist.

Fixes #8 .

k----n commented 6 years ago

Something is wrong with $GITHUB_ACCESS_TOKEN?

CI fails for python 3.6 .

k----n commented 5 years ago
k----n commented 4 years ago

@dahlia Implemented your suggested changes for non-existent entities, all checks pass

k----n commented 4 years ago

Thanks for your contribution!

Thanks for the guidance on better code! Much appreciated.