dahlia / wikidata

Wikidata client library for Python
https://pypi.org/project/Wikidata/
GNU General Public License v3.0
337 stars 31 forks source link

Fix info deletion on cached entities #24

Closed hcordobest closed 4 years ago

hcordobest commented 4 years ago

popitem() removes the item from the list. When using the MemoryCache option, this will cause an Exception because the expected element will not be present when accessing the entity more than once.

This change will keep the elements. The order is not guaranteed (which is good?)

dahlia commented 4 years ago

@hcordobest Sorry for my late response. Could you write a changelog for this bugfix? See the docs/changes.rst file.

hcordobest commented 4 years ago

Done!