search

dahlia / wikidata

Wikidata client library for Python
https://pypi.org/project/Wikidata/
GNU General Public License v3.0
337 stars 31 forks source link

Add tox to setup.cfg options.extras_require tests #25

Closed nelson-liu closed 4 years ago

nelson-liu commented 4 years ago

This makes it easier to test / reproduce the CI environment locally.

nelson-liu commented 4 years ago

yeah, it does—not entirely clear to me that it's a major issue, though. As someone who was first looking at this code, there wasn't any indication of how to test besides the tox.ini, and I was a bit confused when tox wasn't installed with just a pip install -e . . Only after digging through the repo and reading the travis config did I figure out that tox was installed separately.

dahlia commented 4 years ago

IMHO having CONTRIBUTING docs would be more helpful. Even if tox is added to extras_require a pip install -e . command still does not install tox… Also even if a contributor installs .[tests] instead they still need to be aware that they need to run tox.

nelson-liu commented 4 years ago

that sounds reasonable to me