dahliaOS / pangolin_desktop

Pangolin Desktop UI shell, designed for dahliaOS, written in Flutter.
https://web.dahliaos.io
Apache License 2.0
1.89k stars 190 forks source link

dahliaOS needs updates of Material2 to Material3 #385

Closed ghost closed 5 months ago

ghost commented 5 months ago

Is there an existing issue for this?

Current behavior

Hi, I have a report of many problems with dahliaOS with Material3, and frankly, I am a reviewer and I have an new reports

Did you remember the problems of Material1 to Material2 Yes, it's the same thing here, I did everything as flutter user, but the problem with pub is that almost all of it has become Material3, and in order to be like us, your system must be fresh GNULinux/MacOS/WindowsNT or flutter must be fresh and clean cache, config, data,

If you want to know about changes to Flutter, go to ./flutter/packages/flutter/lib/fix_data

some files needs add urls on pubspec.yaml surfaceColor = isn't defined for flutter:ThemeData foregroundColor = isn't defined for flutter:ThemeData methodCall.sender = error 'String?' for pangolin:status_watcher divisions & label & height = No named parameter with the name for pangolin:qs_slider ZenitSlider = Found this candidate, but the arguments don't match for zenit_ui:slider PopScope = isn't defined for '_ZenitPortraitLayoutState' or zenit_ui:zenit_portrait_layout testWidgets & WidgetTester + MyApp + expect + find + findsOneWidget + findsNothing = isn't defined for pangolin:widget_test The parameter type of '==' operators should be non-nullable, Try using a non-nullable type for pangolin:xpm.dart

and some idea with system_recovery, needs (sdk: '>=2.7.0 <3.0.0)

I will NOT close this topic unless you fix it in front of me

Screenshot from 2024-04-29 20-23-40 Screenshot from 2024-05-02 21-52-35

Expected behavior

It could be solved if they created import material2.dart or fixed this problems, And like this : foregroundColor = replaced with colorScheme.onSurfaceVariant surfaceColor replaced with colorScheme.onSurface

Steps to reproduce

No response

Environment (values that do not apply assign with "N/A")

- OS: Gnu/Linux/NixOS/Nixpkgs
- Device: Old/Laptop/Bios/Intel

Anything else?

I also have a problem with dahliaOS/Discord, but nevermind

and I don't like Indian dramas on dahliaOS/Discord, but anyway

Code of Conduct

nmcain commented 5 months ago

You are more than welcome to fix these issues. You have provided solutions, submit them as a pull request making these changes, and we will review it.

On Sun, May 5, 2024, 3:33 PM Redgirl @.***> wrote:

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

Hi, I have a report of many problems with dahliaOS with Material3, and frankly, I am a reviewer and I have an new reports

Did you remember the problems of Material1 to Material2 Yes, it's the same thing here, I did everything as flutter user, but the problem with pub is that almost all of it has become Material3, and in order to be like us, your system must be fresh GNULinux/MacOS/WindowsNT or flutter must be fresh and clean cache, config, data,

If you want to know about changes to Flutter, go to ./flutter/packages/flutter/lib/fix_data

some files needs add urls on pubspec.yaml surfaceColor = isn't defined for flutter:ThemeData foregroundColor = isn't defined for flutter:ThemeData methodCall.sender = error 'String?' for pangolin:status_watcher divisions & label & height = No named parameter with the name for pangolin:qs_slider ZenitSlider = Found this candidate, but the arguments don't match for zenit_ui:slider PopScope = isn't defined for '_ZenitPortraitLayoutState' or zenit_ui:zenit_portrait_layout testWidgets & WidgetTester + MyApp + expect + find + findsOneWidget + findsNothing = isn't defined for pangolin:widget_test The parameter type of '==' operators should be non-nullable, Try using a non-nullable type for pangolin:xpm.dart

and some idea with system_recovery, needs (sdk: '>=2.7.0 <3.0.0)

I will NOT close this topic unless you fix it in front of me

Screenshot.from.2024-04-29.20-23-40.png (view on web) https://github.com/dahliaOS/pangolin_desktop/assets/168940372/4322d9ef-afa4-4027-8599-9d03dac5288c Screenshot.from.2024-05-02.21-52-35.png (view on web) https://github.com/dahliaOS/pangolin_desktop/assets/168940372/dd255280-addb-4cd7-8a55-85b5323c0b19 Expected behavior

It could be solved if they created import material2.dart or fixed this problems, And like this : foregroundColor = replaced with colorScheme.onSurfaceVariant surfaceColor replaced with colorScheme.onSurface Steps to reproduce

No response Environment (values that do not apply assign with "N/A")

  • OS: Gnu/Linux/NixOS/Nixpkgs- Device: Old/Laptop/Bios/Intel

Anything else?

I also have a problem with dahliaOS/Server because I'm been banned without any evidence or warning, or why, I just said the bug truth and posted it here again, ff there is any discussion outside our topic here, unban me in dahliaOS/discord

and I don't like Indian dramas on dahliaOS/Discord for this reason, I rated the dahliaOS/discord at 4/10 because there are really good people there and some that if I were a manager I would kick out of my office Code of Conduct

  • I agree to follow this project's Code of Conduct

— Reply to this email directly, view it on GitHub https://github.com/dahliaOS/pangolin_desktop/issues/385, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEOTEHFKPLK7IZIMLL4FC7DZA2CPLAVCNFSM6AAAAABHH64IESVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3TSNRZGM4DSNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

NhSimple commented 5 months ago

why is this closed when the issue is unsolved?

nmcain commented 3 months ago

why is this closed when the issue is unsolved?

This issue is closed as future plans for Pangolin will resolve it. The requestor in question has refused a number of novel solutions to the problem (i.e downgrading the Flutter SDK and Pangolin via git), which resolve this.

NhSimple commented 3 months ago

oh. i was unaware. i will try to downgrade flutter, thanks.

ghost commented 3 months ago

oh. i was unaware. i will try to downgrade flutter, thanks.

I do not advise you to do so because Zenit_ui is under development and many changes have been made

If you really want to try it, you must be a Flutter developer with fork Pangolin_desktop and fork Zenit_ui too

Or just stay tuned for updates better for you, and i do not want this discussion to loop,

So, you are always welcome.

nmcain commented 3 months ago

oh. i was unaware. i will try to downgrade flutter, thanks.

I do not advise you to do so because Zenit_ui is under development and many changes have been made

If you really want to try it, you must be a Flutter developer with fork Pangolin_desktop and fork Zenit_ui too

Or just stay tuned for updates better for you, and i do not want this discussion to loop,

So, you are always welcome.

Downgrade Pangolin to commit hash 097f85a1d982817e2b9672f6935e28a87ef98050, and Flutter to 017fc6c907eada9204ccc9885462f9efe9625bcb, fix the dependencies as needed, and it will run fine. Alternatively, there's a Linux binary of the last working version HERE