search

dahosek / finl_unicode

Unicode support for the finl project
Apache License 2.0
13 stars 7 forks source link

Ship generated data instead of using build.rs #1

Closed Kijewski closed 1 year ago

Kijewski commented 1 year ago

A crate that accesses the internet during its build is extremely suspicious, even if it's only the Unicode data. Please just ship the derived data instead of building it on the fly.

docs.rs failed to build your crate, because it does not allow net access. For many users this will be the same, and they won't be able to use your project.

Kijewski commented 1 year ago

The documentation still doesn't build: https://docs.rs/crate/finl_unicode/1.0.1/builds/620110

Using a build script should be the last resort, if the information cannot be generated in advance.

dahosek commented 1 year ago

Yeah, I saw that. I’m working out how to restructure things so that I don’t use a build.rs, see https://www.reddit.com/r/rust/comments/x1nrtg/how_to_structure_replacement_for_buildrs_that/

Kijewski commented 1 year ago

Have a look if you can copy some ideas from https://github.com/Kijewski/tzdb. E.g. the Makefile, make-finl_unicode instead of make-tzdb, etc.