search

dahstar / googletest

Automatically exported from code.google.com/p/googletest
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

abort in param tests not supported on WinCE #362

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I changed the occurence of abort to posix::Abort() and the code compiles again 
for Windows CE.

Original issue reported on code.google.com by phil.kur...@gmail.com on 25 Mar 2011 at 12:31

GoogleCodeExporter commented 9 years ago 
What is the error message you are getting and what is the code that is 
triggering it?

Original comment by vladlosev on 28 Mar 2011 at 6:19

GoogleCodeExporter commented 9 years ago 
error message is "undefined symbol 'abort'" in gtest-typed-test.cc(101)

const String& errors_str = errors.GetString();
  if (errors_str != "") {
    fprintf(stderr, "%s %s", FormatFileLocation(file, line).c_str(),
            errors_str.c_str());
    fflush(stderr);
    abort();
  }

changing the abort to posix::Abort(); makes the compiler happy.

Original comment by phil.kur...@gmail.com on 28 Mar 2011 at 6:28

GoogleCodeExporter commented 9 years ago 
You must have some old version of the file. This has been fixed in 2009 and the 
fix has been available since the release 1.5 
(http://code.google.com/p/googletest/source/browse/tags/release-1.5.0/src/gtest-
typed-test.cc#101).

Original comment by vladlosev on 28 Mar 2011 at 10:42

GoogleCodeExporter commented 9 years ago 
It would help everyone tremendously if you included the version of your gtest 
in your initial bug report.  Also, please try to post on the mailing list first 
-- that's monitored by many more people and can get you an answer much faster.

Original comment by w...@google.com on 28 Mar 2011 at 10:56

GoogleCodeExporter commented 9 years ago 
Uhmm I terribly sorry, the bug was actually in 
include\gtest\internal\gtest-param-util.h(582). After checking again. I am 
using the newest 1.6 release.

In that line there is still only an abort() which will fail on Windows Mobile 
(CE).
I changed it to posix::Abort(); and the code compiles.

Original comment by phil.kur...@gmail.com on 29 Mar 2011 at 6:46

GoogleCodeExporter commented 9 years ago

Original comment by vladlosev on 29 Mar 2011 at 11:44

GoogleCodeExporter commented 9 years ago 
Fixed in revision 559.

Original comment by vladlosev on 30 Mar 2011 at 10:03