dahtah / imager

R package for image processing
GNU Lesser General Public License v3.0
187 stars 43 forks source link

Remove plyr dependencies #98

Closed srvanderplas closed 5 years ago

srvanderplas commented 5 years ago

Issue 70 discusses removing plyr from the dependency list. I have gone through the functions and removed plyr-based functions, replacing them with purrr where possible. In the case of plyr::rename, I have added the rename function code from plyr under the name rename_plyr - the functionality wasn't easily matched using the dplyr equivalent, but that one dependency doesn't justify importing the entire plyr package, so I did as suggested in Hadley's R Packages book and duplicated the function.

dahtah commented 5 years ago

Hi - thanks for doing this, it's really welcome. Why did you close the PR, though?

srvanderplas commented 5 years ago

I found another instance I'd missed and didn't have time to fix it just then. I will try to get to it tomorrow 😊.

On Sun, Jun 2, 2019, 03:42 Simon Barthelmé notifications@github.com wrote:

Reopened #98 https://github.com/dahtah/imager/pull/98.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/dahtah/imager/pull/98?email_source=notifications&email_token=AAQHKFITXT5KDD2MKLO4O6DPYOBVTA5CNFSM4HR2S5N2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORYFPGAQ#event-2383082242, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQHKFL7KKWBCA45NJMRXYTPYOBVTANCNFSM4HR2S5NQ .

srvanderplas commented 5 years ago

Ok, Travis is passing now, so let me know if there's anything else that you need me to fix!

Bisaloo commented 5 years ago

Thanks a bunch @srvanderplas for your work on this and @dahtah for review and merging! This is awesome!