PA Review: User Authentication

dahveed15 / Bickr

1 stars 0 forks source link

PA Review: User Authentication #3

Open dahveed15 opened 6 years ago

dahveed15 commented 6 years ago

[x] Backend: DB, model, controller, views
[x] Redux Loop: ajax, actions, reducer
[x] Presentational Components
[x] Styling
[x] Smooth, bug-free navigation
[x] Adequate and appropriate seeds

niartenyaw commented 6 years ago

Nice, looks good! See feedback below:

Functionality

[ ] I would like to click the Bickr logo and go to /
[ ] Would like to be able to use the demo login button on the Sign Up page too

Styling

[ ] The Sign Up and Login buttons in the nav bar need to be styled
[ ] Hovering the buttons on the form should change my cursor to pointer
[ ] Might also want to add some kind of hover effect (maybe slight color change)

dahveed15 commented 6 years ago

Sweet, I think I did what you asked for. I also decided to style the home page and added a hover effect on the sign up button.

niartenyaw commented 6 years ago

Awesome looks good! As you complete them, feel free to check them off on the list. I had a few other things that aren't required for this mvp, but should be done eventually.

Feel free to close this and create the following as separate issues that you can close yourself:

I shouldn't be able to vertically scroll on /, signup, and login when signed out. I think those shouldn't take up more than one page