PA Review: Photos - Githubissues

dahveed15 / Bickr

1 stars 0 forks source link

PA Review: Photos #5

Open dahveed15 opened 6 years ago

dahveed15 commented 6 years ago

Go to /albums to view the functionality

[x] created the CRUD functionality for users to be able to add as many photos that they want for any album that they want
[x] decent css styling (applying masonry would be ideal. Still trying to figure that out)

niartenyaw commented 6 years ago

Sweet!

Functionality

[x] The modal should automatically close once the image is uploaded
[x] When I delete a photo, it should reroute me, probably to its album's show

Styling

[x] Try something like this to style the photo index:


ul.photo-list {
display: flex;
flex-wrap: wrap;
justify-content: center; // center things vertically
}

.photo-list a img { margin: 0 10px; // Separate each picture a bit to the left and right max-width: 300px; // don't let pictures get wider than 300px }

dahveed15 commented 6 years ago

Thanks for that css. That looks great!