emhancement request - update with octane 2.0

[smartmouse]

Hello octane 2.0 is available, will you be updating this anytime soon? Thanks

[dai-shi]

Thanks for the note. Being busy recently but I can work on it sometime later.

https://developers.google.com/octane/benchmark I hope it shouldn't be too different.

[smartmouse]

You are awesome. They have introduced some new additional benchmark zlib and typescript, they also fixed some issues. Can't wait. Appreciated your effort.

[smartmouse]

Hey, if we are to apply the octane 2 manually and do the following steps:

1. do npm install benchmark onctane
2. cd node_modules/benchmark-octane
3. npm install
4. cd lib
5. copy the contents of the new octane-2 to the lib
6. modify octane.js to include the new javascripts

7 then go back to node_modules/benchmark-octane. 8 do node run.js

Will this be sufficient? or there are places you made some customization that we need to fix up in order to make this work?

Thanks in advance

[dai-shi]

Hopefully that is sufficient, but it depends on how much is changed in octane 2.0. Please give it a try. If it works, it works:-)

[smartmouse]

got into the following issue. C:\testoctane\node_modules\benchmark-octane>node run.js

C:\testoctane\node_modules\benchmark-octane\node_modules\benchmark\benchmark.js: 2108 if ((event.result = listener.apply(me, args)) === false) { ^ TypeError: Object 8200 has no method 'apply' at C:\testoctane\node_modules\benchmark-octane\node_modules\benchmark\benchm ark.js:2108:38 at forEach (C:\testoctane\node_modules\benchmark-octane\node_modules\benchma rk\benchmark.js:1527:11) at Benchmark.emit (C:\testoctane\node_modules\benchmark-octane\node_modules\ benchmark\benchmark.js:2107:7) at cycle (C:\testoctane\node_modules\benchmark-octane\node_modules\benchmark \benchmark.js:2980:13) at Benchmark.run (C:\testoctane\node_modules\benchmark-octane\node_modules\b enchmark\benchmark.js:3021:11) at execute (C:\testoctane\node_modules\benchmark-octane\node_modules\benchma rk\benchmark.js:1700:81) at invoke (C:\testoctane\node_modules\benchmark-octane\node_modules\benchmar k\benchmark.js:1814:18) at compute (C:\testoctane\node_modules\benchmark-octane\node_modules\benchma rk\benchmark.js:2871:5) at Benchmark.run (C:\testoctane\node_modules\benchmark-octane\node_modules\b enchmark\benchmark.js:3026:9) at execute (C:\testoctane\node_modules\benchmark-octane\node_modules\benchma rk\benchmark.js:1700:81)

C:\testoctane\node_modules\benchmark-octane>

On Fri, Apr 4, 2014 at 6:11 PM, Daishi Kato notifications@github.comwrote:

Hopefully that is sufficient, but it depends on how much is changed in octane 2.0. Please give it a try. If it works, it works:-)

Reply to this email directly or view it on GitHubhttps://github.com/dai-shi/benchmark-octane/issues/1#issuecomment-39616741 .

[dai-shi]

I just tried and found the error is reproducible. Give me some more time.

2014/04/05 12:25 smartmouse notifications@github.com

got into the following issue. C:\testoctane\node_modules\benchmark-octane>node run.js

C:\testoctane\node_modules\benchmark-octane\node_modules\benchmark\benchmark.js: 2108 if ((event.result = listener.apply(me, args)) === false) { ^ TypeError: Object 8200 has no method 'apply' at C:\testoctane\node_modules\benchmark-octane\node_modules\benchmark\benchm ark.js:2108:38 at forEach (C:\testoctane\node_modules\benchmark-octane\node_modules\benchma rk\benchmark.js:1527:11) at Benchmark.emit (C:\testoctane\node_modules\benchmark-octane\node_modules\ benchmark\benchmark.js:2107:7) at cycle (C:\testoctane\node_modules\benchmark-octane\node_modules\benchmark \benchmark.js:2980:13) at Benchmark.run (C:\testoctane\node_modules\benchmark-octane\node_modules\b enchmark\benchmark.js:3021:11) at execute (C:\testoctane\node_modules\benchmark-octane\node_modules\benchma rk\benchmark.js:1700:81) at invoke (C:\testoctane\node_modules\benchmark-octane\node_modules\benchmar k\benchmark.js:1814:18) at compute (C:\testoctane\node_modules\benchmark-octane\node_modules\benchma rk\benchmark.js:2871:5) at Benchmark.run (C:\testoctane\node_modules\benchmark-octane\node_modules\b enchmark\benchmark.js:3026:9) at execute (C:\testoctane\node_modules\benchmark-octane\node_modules\benchma rk\benchmark.js:1700:81)

C:\testoctane\node_modules\benchmark-octane>

On Fri, Apr 4, 2014 at 6:11 PM, Daishi Kato notifications@github.comwrote:

Hopefully that is sufficient, but it depends on how much is changed in octane 2.0. Please give it a try. If it works, it works:-)

Reply to this email directly or view it on GitHubhttps://github.com/dai-shi/benchmark-octane/issues/1#issuecomment-39616741 .

\ Reply to this email directly or view it on GitHub.

[dai-shi]

I just updated with octane 2.0 but it is not fully working yet. Pushed to master.

[smartmouse]

Hi Daishi: Thank you :-)

What do you mean by not fulling working yet? What are the remaining issues? Just want to be aware of. Thanks so much.

On Mon, Apr 7, 2014 at 9:19 AM, Daishi Kato notifications@github.comwrote:

I just updated with octane 2.0 but it is not fully working yet. Pushed to master.

Reply to this email directly or view it on GitHubhttps://github.com/dai-shi/benchmark-octane/issues/1#issuecomment-39728125 .

[dai-shi]

Yeah, there are remaining issues. Unless they are resolved, I can't release the new version.

[dai-shi]

Thanks so much to #2, it's now working with 2.0. Published as a new version.