search

dai-shi / use-context-selector

React useContextSelector hook in userland
https://www.npmjs.com/package/use-context-selector
MIT License
2.68k stars 61 forks source link

disable minification on compile #112

Closed dai-shi closed 8 months ago

dai-shi commented 11 months ago

To investigate the issue: #110, https://github.com/dai-shi/react-tracked/issues/193, https://github.com/dai-shi/react-tracked/issues/198

codesandbox-ci[bot] commented 11 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 98f77a9637da643c2eb766882bc885f795ed21bc:

Sandbox Source
React Configuration
React TypeScript Configuration
dai-shi commented 11 months ago

@VictorPrata @sfl-moneytree @orkanylmz @tunghs217 Can any one try this and see where exactly the error happens in react-native 0.72?

https://ci.codesandbox.io/status/dai-shi/use-context-selector/pr/112 ☝️ Find "Local Install Instructions"

RodSarhan commented 11 months ago

I tried the local install and this is the error that i got

TypeError: arg[0].startsWith is not a function (it is undefined), js engine: hermes
Error: While trying to resolve module `use-context-selector` from file `MY FILE PATH`, the package `MY PATH/node_modules/use-context-selector/package.json` was successfully found. However, this package itself specifies a `main` module field that could not be resolved

i also remember seeing something related to this line

const runWithNormalPriority = runWithPriority
  ? (thunk: () => void) => runWithPriority(NormalPriority, thunk)
  : (thunk: () => void) => thunk();

but can't seem to reproduce that again

dai-shi commented 11 months ago

Thanks. Hmm, it seems a different error from "Not Implemented".