dai-shi / waku

⛩️ The minimal React framework
https://waku.gg
MIT License
4.08k stars 108 forks source link

feature: better frameworks like cli #115

Closed vasucp1207 closed 9 months ago

vasucp1207 commented 10 months ago

Method like other frameworks use(mainly vue).

Cli including,

Should try to commit in https://github.com/dai-shi/waku/pull/52 but I messed up and also thought it's a completely new strategy so I raised this PR instead.

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 10:59pm
codesandbox-ci[bot] commented 10 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4c549d93cf1e76e612f2e1ce89840bc27bb39ff1:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
React Configuration
React Typescript Configuration
dai-shi commented 10 months ago

Does this cover #81? Can you also take #89 into account?

vasucp1207 commented 10 months ago

Regarding https://github.com/dai-shi/waku/pull/89 , templates only contain necessary files it does not include folders like node_modules etc. Well if you run npm run build a resulted out.cjs file is generated, but I can't figure out now how to publish it to npm to actually check it. Do you have any idea about this.

dai-shi commented 10 months ago

Regarding #89 , templates only contain necessary files it does not include folders like node_modules etc.

As I understand, #89's request is just to put .gitignore file in those templates. But, on second thought, I'm not sure what should be in there. Does create-vue generate .gitignore file?

vasucp1207 commented 10 months ago

Regarding #89 , templates only contain necessary files it does not include folders like node_modules etc.

As I understand, #89's request is just to put .gitignore file in those templates. But, on second thought, I'm not sure what should be in there. Does create-vue generate .gitignore file?

Yes, create-vue generates a .gitignore file, I think a minimal file is okay for this like create-vue .gitignore

dai-shi commented 10 months ago

Please also take care of CI errors.

vasucp1207 commented 10 months ago

Please check CI errors too.

I also run prettier, don't know why it fails

dai-shi commented 10 months ago

Maybe we need to add the empty config line https://github.com/dai-shi/waku/blob/33c41546aac3be3d706f22a055589ef82398b0f4/package.json#L93 in create-waku/package.json too.

dai-shi commented 9 months ago

@vasucp1207 #122 is merged. Please follow the new structure.

dai-shi commented 9 months ago

Please check CI errors.

dai-shi commented 9 months ago

https://www.npmjs.com/package/create-waku/v/0.5.1 is published. @vasucp1207 Can you please check if it works as expected?