dai-shi / waku

⛩️ The minimal React framework
https://waku.gg
MIT License
4.08k stars 108 forks source link

Update react canary #399

Closed dai-shi closed 4 months ago

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Jan 21, 2024 2:32am
codesandbox-ci[bot] commented 5 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2b2dbe8d0c09ccfc3fe23ac7fd27bd38b4b05b66:

Sandbox Source
Vanilla Typescript Configuration
React Configuration
React TypeScript Configuration
dai-shi commented 5 months ago

npm run website:dev causes this: image

dai-shi commented 5 months ago

it works without ssr, but keep it for now.

diff --git a/packages/website/package.json b/packages/website/package.json
index 6520efc..a0f7965 100644
--- a/packages/website/package.json
+++ b/packages/website/package.json
@@ -5,7 +5,7 @@
   "type": "module",
   "private": true,
   "scripts": {
-    "dev": "waku dev --with-ssr",
+    "dev": "waku dev",
     "build": "waku build --with-ssr",
     "start": "waku start --with-ssr"
   },
dai-shi commented 5 months ago

it has such an e2e test. 😓

dai-shi commented 4 months ago

All fixed including the issue I noted above.

ryota-murakami commented 4 months ago

@dai-shi Where latest canary release changelog are you getting from? And packages/waku/src/client.ts change is for fix breaking via update canary version?

dai-shi commented 4 months ago

here: https://github.com/facebook/react/compare/c5b937576...b30030471 And yes.

ryota-murakami commented 4 months ago

@dai-shi Thanks, I learned canary versioning id is just a commit hash. 😅