dai-shi / waku

⛩️ The minimal React framework
https://waku.gg
MIT License
4.08k stars 108 forks source link

test: update standalone test #420

Closed himself65 closed 4 months ago

himself65 commented 4 months ago

Upstream: https://github.com/dai-shi/waku/pull/374

Real standalone test:

  1. isolated environment
  2. install waku by file package instead of copy files
vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **waku** | ⬜️ Ignored ([Inspect](https://vercel.com/daishi/waku/6cWwBmnA5TU9aFVgZ2hbohejMsJZ)) | [Visit Preview](https://waku-git-fork-himself65-himself65-update-standalone-daishi.vercel.app) | Feb 17, 2024 4:52am |
codesandbox-ci[bot] commented 4 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

himself65 commented 4 months ago

I dont know why!!!

Aslemammad commented 4 months ago

@himself65 If you still have issue with this I can take a look later, if yes, then I'd be happy if @dai-shi would assign me here.

himself65 commented 4 months ago

@himself65 If you still have issue with this I can take a look later, if yes, then I'd be happy if @dai-shi would assign me here.

If you revert this, commit you will see af47f13 (#420)

Only on Windows on CI, but it works well on my windows...

himself65 commented 4 months ago

Let me reproduce this step by step🤔

himself65 commented 4 months ago

@Aslemammad yes we can see

Aslemammad commented 4 months ago

@himself65 can we rebase this first so I can see the issue with newer results? because apparently the counter example is removed.

dai-shi commented 4 months ago

@Aslemammad If you like, you can fork and open a new PR.

himself65 commented 4 months ago

rebased

dai-shi commented 4 months ago

https://github.com/dai-shi/waku/pull/471/files#r1485443331

shouldn't we also test --with-ssr?

dai-shi commented 4 months ago

I'm looking forward to this very much. Please make it ready for review when the issue is resolved.

himself65 commented 4 months ago

let me do this this weekend 💪