Closed himself65 closed 3 months ago
Seems like it's the issue on dynamic page
Thanks for reporting. Can we reproduce it with examples/01_template with changing render: 'dynamic'
for path: '/'
?
Thanks for reporting. Can we reproduce it with examples/01_template with changing
render: 'dynamic'
forpath: '/'
?
im adding the test case now
Oh, I think it's my custom app logic issue, here is fallback in waku start
if (!options.ssr) {
// history api fallback
app.use(
'*',
serveStatic({
root: path.join(distDir, publicDir),
rewriteRequestPath: () => '/',
}),
);
}
what's your custom app logic? is your options.ssr
false?
Yeah, I disabled SSR because it's a electron app, which run waku
Is it specific to /
? I wonder if it causes the same issue with path: '/foo/[id]'
.
It might be related to #534, which i'm currently working on.
Closing as this is not a bug in waku, but still need to update the document and cover the test
Solution: https://github.com/dai-shi/waku/issues/536#issuecomment-1963177880
Okay, I think I understand the problem.
When /
is dynamic, we don't create dist/public/index.html
,
then history api fallback doesn't work.
(I will think about it.)
Okay, I think I understand the problem. When
/
is dynamic, we don't createdist/public/index.html
, then history api fallback doesn't work. (I will think about it.)
Maybe we should fall back to SPA?
workaround is to use Link