search

dai-shi / waku

⛩️ The minimal React framework
https://waku.gg
MIT License
4.07k stars 107 forks source link

html-renderer: Simplify module loading for react and rsdw-client #612

Open Tobbe opened 2 months ago

Tobbe commented 2 months ago

In my testing I discovered that react and react-dom-server-webpack/client.edge could be imported using regular imports. No need to have a local build of those and import that build.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Mar 21, 2024 8:41am
codesandbox-ci[bot] commented 2 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

dai-shi commented 2 months ago

Nice finding. It must have been improved in some PRs like #457 or something.

I'd like to keep it as is for v0.20.0 and investigate more to understand why rd-server and waku-client can't be imported. With that, we will be confident to merge this.

Marking as draft until then.