search

dai-shi / waku

⛩️ The minimal React framework
https://waku.gg
MIT License
4.01k stars 104 forks source link

fix: split any filepath by `?` #614

Closed Aslemammad closed 2 months ago

Aslemammad commented 2 months ago

Resolves #611

Apparently, the ./router/client.js?v=a3348fd2 query occurs in monorepos for non /@fs/ paths.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Mar 24, 2024 4:07am
codesandbox-ci[bot] commented 2 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

dai-shi commented 2 months ago

Apparently, the ./router/client.js?v=a3348fd2 query occurs in monorepos for non /@fs/ paths.

Do you mean the opposite? Previously, it handles /@fs/ paths only. Also, I guess this is DEV only issue, so we want the fix in if (isDev) condition.

Aslemammad commented 2 months ago

Do you mean the opposite?

Yep, I mean now it occurs for both of the conditions.